-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified admin rpc #26
Conversation
…rpc from the txsvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The join status and list endpoints are semi-public and don't involve txns, but it does seem best in admin regardless.
I suppose we'll wait to merge this until kwilteam/kwil-db#403 is ready?
Yeah they should probably get merged at the same time. We can move the join-status and list to the txsvc if we want; the admin svc has access to the tx svc anyways |
Is this going in this week's release? Or after? |
This week |
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
Due to the proto change (here: kwilteam/proto#26 (comment)), KwilD now returns list database an array of the owner, db name, and dbid. There interface on the listDatabases request now matched that, returning the owner as a Uint8Array. BREAKING CHANGE: The kwil.listDatabases() method now returns an array of db-objects (owner, identifier, dbid). Previously, only the db name would be returned when an owner's address was passed to `listDatabases()`.
This PR includes:
function
svc, based on the auxiliaryVerifySignature
rpc we have (we will likely expand on these auxiliaries as the gateway's responsibilities / other services we sell grow).